Skip to content

Conversation

@greazer
Copy link
Member

@greazer greazer commented Nov 5, 2019

For #8373

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@greazer greazer added the no-changelog No news entry required label Nov 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #8374 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8374      +/-   ##
==========================================
+ Coverage   59.02%   59.35%   +0.32%     
==========================================
  Files         509      509              
  Lines       23285    23285              
  Branches     3757     3762       +5     
==========================================
+ Hits        13745    13820      +75     
+ Misses       8641     8566      -75     
  Partials      899      899
Impacted Files Coverage Δ
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 70.51% <0%> (+12.82%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 80% <0%> (+20%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a6e24...8f616d7. Read the comment docs.

@greazer greazer requested a review from rchiodo November 5, 2019 19:17
@greazer greazer merged commit 5489cf1 into master Nov 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2019
@kimadeline kimadeline deleted the dev/jimgries/interactive-gather-from branch November 28, 2019 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants